Browse Source

User will see profile edit page if giving an invalid tab name

pull/67/merge
Nafies Luthfi 5 years ago
parent
commit
35224c991a
  1. 4
      resources/views/users/edit.blade.php
  2. 10
      tests/Feature/UsersProfileTest.php

4
resources/views/users/edit.blade.php

@ -22,7 +22,7 @@
<div class="row">
{{ Form::model($user, ['route' => ['users.update', $user->id], 'method' =>'patch', 'autocomplete' => 'off']) }}
<div class="col-md-6">
@includeWhen(request('tab') == null, 'users.partials.edit_profile')
@includeWhen(request('tab') == null || !in_array(request('tab'), ['death', 'contact_address', 'login_account',]), 'users.partials.edit_profile')
@includeWhen(request('tab') == 'death', 'users.partials.edit_death')
@includeWhen(request('tab') == 'contact_address', 'users.partials.edit_contact_address')
@includeWhen(request('tab') == 'login_account', 'users.partials.edit_login_account')
@ -33,7 +33,7 @@
</div>
{{ Form::close() }}
<div class="col-md-6">
@includeWhen(request('tab') == null, 'users.partials.update_photo')
@includeWhen(request('tab') == null || !in_array(request('tab'), ['death', 'contact_address', 'login_account',]), 'users.partials.update_photo')
</div>
</div>
</div>

10
tests/Feature/UsersProfileTest.php

@ -35,6 +35,16 @@ class UsersProfileTest extends TestCase
}
/** @test */
public function user_will_see_edit_profile_if_an_invalid_tab_selected()
{
$user = $this->loginAsUser();
$this->visit(route('users.edit', [$user->id, 'tab' => 'invalid_tab']));
$this->seePageIs(route('users.edit', [$user->id, 'tab' => 'invalid_tab']));
$this->seeElement('input', ['name' => 'nickname']);
$this->seeElement('input', ['name' => 'name']);
}
/** @test */
public function user_can_edit_profile()
{
$user = $this->loginAsUser();

Loading…
Cancel
Save