From 4b9ef3ac3481924547eb35e9a6f010bcd3220c8c Mon Sep 17 00:00:00 2001 From: Nafies Luthfi Date: Fri, 30 Apr 2021 22:50:56 +0800 Subject: [PATCH] Refactor updateUserMetadata method --- app/Http/Controllers/UsersController.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/Http/Controllers/UsersController.php b/app/Http/Controllers/UsersController.php index c442bfc..f825893 100644 --- a/app/Http/Controllers/UsersController.php +++ b/app/Http/Controllers/UsersController.php @@ -272,11 +272,9 @@ class UsersController extends Controller if ($userAttributes->has($key) == false) { continue; } - $userMeta = UserMetadata::where('user_id', $user->id)->where('key', $key)->firstOrNew(); + $userMeta = UserMetadata::firstOrNew(['user_id' => $user->id, 'key' => $key]); if (!$userMeta->exists) { $userMeta->id = Uuid::uuid4()->toString(); - $userMeta->user_id = $user->id; - $userMeta->key = $key; } $userMeta->value = $userAttributes->get($key); $userMeta->save();