odon
/
silsilah
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

Refactor user replace and delete to a job

pull/65/head
Nafies Luthfi 5 years ago
parent
4403397340
commit
329f955780
2 changed files with 97 additions and 84 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 86
      app/Http/Controllers/UsersController.php
  2. 95
      app/Jobs/Users/DeleteAndReplaceUser.php

86
app/Http/Controllers/UsersController.php
View File

@ -4,8 +4,8 @@ namespace App\Http\Controllers;
use App\Couple; use App\Couple;
use App\Http\Requests\Users\UpdateRequest; use App\Http\Requests\Users\UpdateRequest;
use App\Jobs\Users\DeleteAndReplaceUser;
use App\User; use App\User;
use DB;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Storage; use Storage;
@ -146,12 +146,7 @@ class UsersController extends Controller
'replacement_user_id.required' => __('validation.user.replacement_user_id.required'), 'replacement_user_id.required' => __('validation.user.replacement_user_id.required'),
]); ]);
DB::beginTransaction();
$this->replaceUserOnUsersTable($user->id, $attributes['replacement_user_id']);
$this->removeDuplicatedCouples($user->id, $attributes['replacement_user_id']);
$this->replaceUserOnCouplesTable($user->id, $attributes['replacement_user_id']);
$user->delete();
DB::commit();
$this->dispatchNow(new DeleteAndReplaceUser($user, $attributes['replacement_user_id']));
return redirect()->route('users.show', $attributes['replacement_user_id']); return redirect()->route('users.show', $attributes['replacement_user_id']);
} }
@ -191,83 +186,6 @@ class UsersController extends Controller
} }
/** /**
* Replace User Ids on users table.
*
* @param string $oldUserId
* @param string $replacementUserId
* @return void
*/
private function replaceUserOnUsersTable($oldUserId, $replacementUserId)
{
foreach (['father_id', 'mother_id', 'manager_id'] as $field) {
DB::table('users')->where($field, $oldUserId)->update([
$field => $replacementUserId,
]);
}
}
/**
* Replace User Ids on couples table.
*
* @param string $oldUserId
* @param string $replacementUserId
*
* @return void
*/
private function replaceUserOnCouplesTable($oldUserId, $replacementUserId)
{
DB::table('couples')->where('husband_id', $oldUserId)->update([
'husband_id' => $replacementUserId,
]);
DB::table('couples')->where('wife_id', $oldUserId)->update([
'wife_id' => $replacementUserId,
]);
DB::table('couples')->where('manager_id', $oldUserId)->update([
'manager_id' => $replacementUserId,
]);
}
private function removeDuplicatedCouples($oldUserId, $replacementUserId)
{
$oldUser = User::find($oldUserId);
$replacementUser = User::find($replacementUserId);
if ($replacementUser->gender_id == 1) {
$replacementUserCouples = Couple::where('husband_id', $replacementUserId)->get();
} else {
$replacementUserCouples = Couple::where('wife_id', $replacementUserId)->get();
}
if ($oldUser->gender_id == 1) {
$oldUserCouples = Couple::where('husband_id', $oldUserId)->get();
} else {
$oldUserCouples = Couple::where('wife_id', $oldUserId)->get();
}
$couplesArray = [];
foreach ($replacementUserCouples as $replacementUserCouple) {
$couplesArray[$replacementUserCouple->id] = $replacementUserCouple->husband_id.'_'.$replacementUserCouple->wife_id;
}
foreach ($oldUserCouples as $oldUserCouple) {
$couplesArray[$oldUserCouple->id] = $oldUserCouple->husband_id.'_'.$oldUserCouple->wife_id;
}
$couplesArray = collect($couplesArray);
$deletableCouples = [];
if ($oldUser->gender_id == 1) {
foreach ($oldUserCouples as $oldUserCouple) {
$deletableCouples[] = $couplesArray->search($replacementUserId.'_'.$oldUserCouple->wife_id);
}
} else {
foreach ($oldUserCouples as $oldUserCouple) {
$deletableCouples[] = $couplesArray->search($oldUserCouple->husband_id.'_'.$replacementUserId);
}
}
if ($deletableCouples) {
Couple::whereIn('id', $deletableCouples)->delete();
}
}
/**
* Get User list based on gender. * Get User list based on gender.
* *
* @param int $genderId * @param int $genderId

95
app/Jobs/Users/DeleteAndReplaceUser.php
View File

@ -0,0 +1,95 @@
<?php
namespace App\Jobs\Users;
use App\Couple;
use App\User;
use Illuminate\Support\Facades\DB;
class DeleteAndReplaceUser
{
public $user;
public $replacementUserId;
public function __construct(User $user, string $replacementUserId)
{
$this->user = $user;
$this->replacementUserId = $replacementUserId;
}
public function handle()
{
$user = $this->user;
$replacementUserId = $this->replacementUserId;
DB::beginTransaction();
$this->replaceUserOnUsersTable($user->id, $replacementUserId);
$this->removeDuplicatedCouples($user->id, $replacementUserId);
$this->replaceUserOnCouplesTable($user->id, $replacementUserId);
$user->delete();
DB::commit();
}
private function replaceUserOnCouplesTable($oldUserId, $replacementUserId)
{
DB::table('couples')->where('husband_id', $oldUserId)->update([
'husband_id' => $replacementUserId,
]);
DB::table('couples')->where('wife_id', $oldUserId)->update([
'wife_id' => $replacementUserId,
]);
DB::table('couples')->where('manager_id', $oldUserId)->update([
'manager_id' => $replacementUserId,
]);
}
private function removeDuplicatedCouples(string $oldUserId, string $replacementUserId)
{
$oldUser = User::find($oldUserId);
$replacementUser = User::find($replacementUserId);
if ($replacementUser->gender_id == 1) {
$replacementUserCouples = Couple::where('husband_id', $replacementUserId)->get();
} else {
$replacementUserCouples = Couple::where('wife_id', $replacementUserId)->get();
}
if ($oldUser->gender_id == 1) {
$oldUserCouples = Couple::where('husband_id', $oldUserId)->get();
} else {
$oldUserCouples = Couple::where('wife_id', $oldUserId)->get();
}
$couplesArray = [];
foreach ($replacementUserCouples as $replacementUserCouple) {
$couplesArray[$replacementUserCouple->id] = $replacementUserCouple->husband_id.'_'.$replacementUserCouple->wife_id;
}
foreach ($oldUserCouples as $oldUserCouple) {
$couplesArray[$oldUserCouple->id] = $oldUserCouple->husband_id.'_'.$oldUserCouple->wife_id;
}
$couplesArray = collect($couplesArray);
$deletableCouples = [];
if ($oldUser->gender_id == 1) {
foreach ($oldUserCouples as $oldUserCouple) {
$deletableCouples[] = $couplesArray->search($replacementUserId.'_'.$oldUserCouple->wife_id);
}
} else {
foreach ($oldUserCouples as $oldUserCouple) {
$deletableCouples[] = $couplesArray->search($oldUserCouple->husband_id.'_'.$replacementUserId);
}
}
if ($deletableCouples) {
Couple::whereIn('id', $deletableCouples)->delete();
}
}
private function replaceUserOnUsersTable(string $oldUserId, string $replacementUserId)
{
foreach (['father_id', 'mother_id', 'manager_id'] as $field) {
DB::table('users')->where($field, $oldUserId)->update([
$field => $replacementUserId,
]);
}
}
}
Write Preview
Loading…
Cancel
Save