From 17227f488485f2a74ce4a2276696e9f8af2352bf Mon Sep 17 00:00:00 2001
From: Nafies Luthfi <nafiesl@gmail.com>
Date: Thu, 31 May 2018 09:10:23 +0800
Subject: [PATCH] Add delete user feature (w/o dependency checks)

---
 app/Http/Controllers/UsersController.php | 18 +++++++++++++++---
 resources/lang/en/user.php               |  3 +++
 resources/lang/id/user.php               |  3 +++
 resources/views/users/edit.blade.php     | 25 +++++++++++++++++++++++++
 routes/web.php                           |  1 +
 tests/Feature/UsersDeletionTest.php      | 32 ++++++++++++++++++++++++++++++++
 6 files changed, 79 insertions(+), 3 deletions(-)
 create mode 100644 tests/Feature/UsersDeletionTest.php

diff --git a/app/Http/Controllers/UsersController.php b/app/Http/Controllers/UsersController.php
index a261086..43c1298 100644
--- a/app/Http/Controllers/UsersController.php
+++ b/app/Http/Controllers/UsersController.php
@@ -161,12 +161,24 @@ class UsersController extends Controller
     /**
      * Remove the specified User from storage.
      *
-     * @param  \App\User  $user
+     * @param \Illuminate\Http\Request $request
+     * @param \App\User $user
+     *
      * @return \Illuminate\Http\Response
      */
-    public function destroy(User $user)
+    public function destroy(Request $request, User $user)
     {
-        //
+        $this->authorize('delete', $user);
+
+        request()->validate([
+            'user_id' => 'required',
+        ]);
+
+        if (request('user_id') == $user->id && $user->delete()) {
+            return redirect()->route('users.search');
+        }
+
+        return back();
     }
 
     /**
diff --git a/resources/lang/en/user.php b/resources/lang/en/user.php
index 88de0e6..86aa8e9 100644
--- a/resources/lang/en/user.php
+++ b/resources/lang/en/user.php
@@ -28,6 +28,9 @@ return [
     'add_husband' => 'Add Husband',
     'add_child'   => 'Add Child',
     'add_child_from_existing_couples' => 'Parent (select spouse of :name)',
+    'delete' => 'Delete User',
+    'delete_confirm' => 'Are you sure to delete this user?',
+    'delete_confirm_button' => 'Yes, I am sure',
 
     // Attributes
     'name'     => 'Name',
diff --git a/resources/lang/id/user.php b/resources/lang/id/user.php
index f417821..dd73db3 100644
--- a/resources/lang/id/user.php
+++ b/resources/lang/id/user.php
@@ -28,6 +28,9 @@ return [
     'add_husband' => 'Tambah Suami',
     'add_child'   => 'Tambah Anak',
     'add_child_from_existing_couples' => 'Dari Pernikahan (pilih pasangan :name)',
+    'delete' => 'Hapus User',
+    'delete_confirm' => 'Anda yakin akan menghapus user ini?',
+    'delete_confirm_button' => 'Saya yakin hapus user ini',
 
     // Attributes
     'name'     => 'Nama',
diff --git a/resources/views/users/edit.blade.php b/resources/views/users/edit.blade.php
index 22f39c9..7bc7dc6 100644
--- a/resources/views/users/edit.blade.php
+++ b/resources/views/users/edit.blade.php
@@ -1,6 +1,27 @@
 @extends('layouts.app')
 
 @section('content')
+@if (request('action') == 'delete' && $user)
+    @can('delete', $user)
+        <div class="row">
+            <div class="col-md-6 col-md-offset-3">
+                <div class="panel panel-default">
+                    <div class="panel-heading"><h3 class="panel-title">{{ __('user.delete') }} : {{ $user->name }}</h3></div>
+                    <div class="panel-body">{{ __('user.delete_confirm') }}</div>
+                    <div class="panel-footer">
+                        {!! FormField::delete(
+                            ['route' => ['users.destroy', $user]],
+                            __('user.delete_confirm_button'),
+                            ['class'=>'btn btn-danger'],
+                            ['user_id' => $user->id]
+                        ) !!}
+                        {{ link_to_route('users.edit', __('app.cancel'), [$user], ['class' => 'btn btn-default']) }}
+                    </div>
+                </div>
+            </div>
+        </div>
+    @endcan
+@else
     <h2 class="page-header">
         <div class="pull-right">
             {{ link_to_route('users.show', trans('app.show_profile').' '.$user->name, [$user->id], ['class' => 'btn btn-default']) }}
@@ -64,6 +85,10 @@
                 </div>
                 {{ Form::close() }}
             </div>
+            @can('delete', $user)
+                {{ link_to_route('users.edit', __('user.delete'), [$user, 'action' => 'delete'], ['class' => 'btn btn-danger pull-right', 'id' => 'del-user-'.$user->id]) }}
+            @endcan
         </div>
     </div>
+@endif
 @endsection
diff --git a/routes/web.php b/routes/web.php
index d7d5503..d0a974b 100644
--- a/routes/web.php
+++ b/routes/web.php
@@ -31,6 +31,7 @@ Route::patch('users/{user}', 'UsersController@update')->name('users.update');
 Route::get('users/{user}/chart', 'UsersController@chart')->name('users.chart');
 Route::get('users/{user}/tree', 'UsersController@tree')->name('users.tree');
 Route::patch('users/{user}/photo-upload', 'UsersController@photoUpload')->name('users.photo-upload');
+Route::delete('users/{user}', 'UsersController@destroy')->name('users.destroy');
 
 Route::get('users/{user}/marriages', 'UserMarriagesController@index')->name('users.marriages');
 
diff --git a/tests/Feature/UsersDeletionTest.php b/tests/Feature/UsersDeletionTest.php
new file mode 100644
index 0000000..4ebb7f7
--- /dev/null
+++ b/tests/Feature/UsersDeletionTest.php
@@ -0,0 +1,32 @@
+<?php
+
+namespace Tests\Feature;
+
+use App\User;
+use Tests\TestCase;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+class UsersDeletionTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /** @test */
+    public function manager_can_delete_a_user()
+    {
+        $manager = $this->loginAsUser();
+        $user = factory(User::class)->create(['manager_id' => $manager->id]);
+
+        $this->visit(route('users.edit', $user));
+        $this->seeElement('a', ['id' => 'del-user-'.$user->id]);
+
+        $this->click('del-user-'.$user->id);
+        $this->seePageIs(route('users.edit', [$user, 'action' => 'delete']));
+        $this->see(__('user.delete_confirm_button'));
+
+        $this->press(__('user.delete_confirm_button'));
+
+        $this->dontSeeInDatabase('users', [
+            'id' => $user->id,
+        ]);
+    }
+}