Browse Source

Remove variabel that cause invalid redirection

Model variable in update method on controller.full.stub
will always return 1, so it will cause invalid redirection
on every model update action

Remove unused variable on controller update method
tags/1.0.2
Nafies Luthfi 8 years ago
parent
commit
23d701bb31
  1. 2
      src/stubs/controller.full.stub
  2. 2
      src/stubs/controller.simple.stub
  3. 6
      tests/Generators/FullControllerGeneratorTest.php
  4. 6
      tests/Generators/Simple/SimpleControllerGeneratorTest.php

2
src/stubs/controller.full.stub

@ -96,7 +96,7 @@ class MastersController extends Controller
'description' => 'nullable|max:255',
]);
$singleMstr = $singleMstr->update($request->only('name', 'description'));
$singleMstr->update($request->only('name', 'description'));
return redirect()->route('masters.show', $singleMstr);
}

2
src/stubs/controller.simple.stub

@ -67,7 +67,7 @@ class MastersController extends Controller
$routeParam = request()->only('page', 'q');
$singleMstr = $singleMstr->update($request->only('name', 'description'));
$singleMstr->update($request->only('name', 'description'));
return redirect()->route('masters.index', $routeParam);
}

6
tests/Generators/FullControllerGeneratorTest.php

@ -110,7 +110,7 @@ class {$this->plural_model_name}Controller extends Controller
'description' => 'nullable|max:255',
]);
\${$this->single_model_var_name} = \${$this->single_model_var_name}->update(\$request->only('name', 'description'));
\${$this->single_model_var_name}->update(\$request->only('name', 'description'));
return redirect()->route('{$this->table_name}.show', \${$this->single_model_var_name});
}
@ -246,7 +246,7 @@ class CategoriesController extends Controller
'description' => 'nullable|max:255',
]);
\$category = \$category->update(\$request->only('name', 'description'));
\$category->update(\$request->only('name', 'description'));
return redirect()->route('categories.show', \$category);
}
@ -383,7 +383,7 @@ class CategoriesController extends Controller
'description' => 'nullable|max:255',
]);
\$category = \$category->update(\$request->only('name', 'description'));
\$category->update(\$request->only('name', 'description'));
return redirect()->route('categories.show', \$category);
}

6
tests/Generators/Simple/SimpleControllerGeneratorTest.php

@ -81,7 +81,7 @@ class {$this->plural_model_name}Controller extends Controller
\$routeParam = request()->only('page', 'q');
\${$this->single_model_var_name} = \${$this->single_model_var_name}->update(\$request->only('name', 'description'));
\${$this->single_model_var_name}->update(\$request->only('name', 'description'));
return redirect()->route('{$this->table_name}.index', \$routeParam);
}
@ -188,7 +188,7 @@ class CategoriesController extends Controller
\$routeParam = request()->only('page', 'q');
\$category = \$category->update(\$request->only('name', 'description'));
\$category->update(\$request->only('name', 'description'));
return redirect()->route('categories.index', \$routeParam);
}
@ -296,7 +296,7 @@ class CategoriesController extends Controller
\$routeParam = request()->only('page', 'q');
\$category = \$category->update(\$request->only('name', 'description'));
\$category->update(\$request->only('name', 'description'));
return redirect()->route('categories.index', \$routeParam);
}

Loading…
Cancel
Save