Browse Source

Merge branch 'request-injection-on-controller-destroy'

tags/1.2.9
Nafies Luthfi 7 years ago
parent
commit
0432cb24fa
  1. 9
      src/stubs/controllers/api.stub
  2. 9
      src/stubs/controllers/full-formrequests.stub
  3. 9
      src/stubs/controllers/full.stub
  4. 9
      src/stubs/controllers/simple.stub
  5. 9
      tests/CommandOptions/FullCrudFormRequestOptionsTest.php
  6. 9
      tests/Generators/Api/ApiControllerGeneratorTest.php
  7. 27
      tests/Generators/FullControllerGeneratorTest.php
  8. 27
      tests/Generators/Simple/SimpleControllerGeneratorTest.php

9
src/stubs/controllers/api.stub

@ -83,18 +83,17 @@ class MasterController extends Controller
/**
* Remove the specified singleMstr from storage.
*
* @param \Illuminate\Http\Request $request
* @param \fullMstr $singleMstr
* @return \Illuminate\Http\JsonResponse
*/
public function destroy(Master $singleMstr)
public function destroy(Request $request, Master $singleMstr)
{
$this->authorize('delete', $singleMstr);
request()->validate([
'master_id' => 'required',
]);
$request->validate(['master_id' => 'required']);
if (request('master_id') == $singleMstr->id && $singleMstr->delete()) {
if ($request->get('master_id') == $singleMstr->id && $singleMstr->delete()) {
return response()->json(['message' => __('master.deleted')]);
}

9
src/stubs/controllers/full-formrequests.stub

@ -89,18 +89,17 @@ class MasterController extends Controller
/**
* Remove the specified singleMstr from storage.
*
* @param \Illuminate\Http\Request $request
* @param \fullMstr $singleMstr
* @return \Illuminate\Routing\Redirector
*/
public function destroy(Master $singleMstr)
public function destroy(Request $request, Master $singleMstr)
{
$this->authorize('delete', $singleMstr);
request()->validate([
'master_id' => 'required',
]);
$request->validate(['master_id' => 'required']);
if (request('master_id') == $singleMstr->id && $singleMstr->delete()) {
if ($request->get('master_id') == $singleMstr->id && $singleMstr->delete()) {
return redirect()->route('masters.index');
}

9
src/stubs/controllers/full.stub

@ -101,18 +101,17 @@ class MasterController extends Controller
/**
* Remove the specified singleMstr from storage.
*
* @param \Illuminate\Http\Request $request
* @param \fullMstr $singleMstr
* @return \Illuminate\Routing\Redirector
*/
public function destroy(Master $singleMstr)
public function destroy(Request $request, Master $singleMstr)
{
$this->authorize('delete', $singleMstr);
request()->validate([
'master_id' => 'required',
]);
$request->validate(['master_id' => 'required']);
if (request('master_id') == $singleMstr->id && $singleMstr->delete()) {
if ($request->get('master_id') == $singleMstr->id && $singleMstr->delete()) {
return redirect()->route('masters.index');
}

9
src/stubs/controllers/simple.stub

@ -72,18 +72,17 @@ class MasterController extends Controller
/**
* Remove the specified singleMstr from storage.
*
* @param \Illuminate\Http\Request $request
* @param \fullMstr $singleMstr
* @return \Illuminate\Routing\Redirector
*/
public function destroy(Master $singleMstr)
public function destroy(Request $request, Master $singleMstr)
{
$this->authorize('delete', $singleMstr);
request()->validate([
'master_id' => 'required',
]);
$request->validate(['master_id' => 'required']);
if (request('master_id') == $singleMstr->id && $singleMstr->delete()) {
if ($request->get('master_id') == $singleMstr->id && $singleMstr->delete()) {
$routeParam = request()->only('page', 'q');
return redirect()->route('masters.index', $routeParam);

9
tests/CommandOptions/FullCrudFormRequestOptionsTest.php

@ -134,18 +134,17 @@ class {$this->model_name}Controller extends Controller
/**
* Remove the specified {$this->single_model_var_name} from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \\{$this->full_model_name} \${$this->single_model_var_name}
* @return \Illuminate\Routing\Redirector
*/
public function destroy({$this->model_name} \${$this->single_model_var_name})
public function destroy(Request \$request, {$this->model_name} \${$this->single_model_var_name})
{
\$this->authorize('delete', \${$this->single_model_var_name});
request()->validate([
'{$this->lang_name}_id' => 'required',
]);
\$request->validate(['{$this->lang_name}_id' => 'required']);
if (request('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
if (\$request->get('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
return redirect()->route('{$this->table_name}.index');
}

9
tests/Generators/Api/ApiControllerGeneratorTest.php

@ -97,18 +97,17 @@ class {$this->model_name}Controller extends Controller
/**
* Remove the specified {$this->single_model_var_name} from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \\{$this->full_model_name} \${$this->single_model_var_name}
* @return \Illuminate\Http\JsonResponse
*/
public function destroy({$this->model_name} \${$this->single_model_var_name})
public function destroy(Request \$request, {$this->model_name} \${$this->single_model_var_name})
{
\$this->authorize('delete', \${$this->single_model_var_name});
request()->validate([
'{$this->lang_name}_id' => 'required',
]);
\$request->validate(['{$this->lang_name}_id' => 'required']);
if (request('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
if (\$request->get('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
return response()->json(['message' => __('{$this->lang_name}.deleted')]);
}

27
tests/Generators/FullControllerGeneratorTest.php

@ -115,18 +115,17 @@ class {$this->model_name}Controller extends Controller
/**
* Remove the specified {$this->single_model_var_name} from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \\{$this->full_model_name} \${$this->single_model_var_name}
* @return \Illuminate\Routing\Redirector
*/
public function destroy({$this->model_name} \${$this->single_model_var_name})
public function destroy(Request \$request, {$this->model_name} \${$this->single_model_var_name})
{
\$this->authorize('delete', \${$this->single_model_var_name});
request()->validate([
'{$this->lang_name}_id' => 'required',
]);
\$request->validate(['{$this->lang_name}_id' => 'required']);
if (request('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
if (\$request->get('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
return redirect()->route('{$this->table_name}.index');
}
@ -246,18 +245,17 @@ class CategoryController extends Controller
/**
* Remove the specified category from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \App\Entities\References\Category \$category
* @return \Illuminate\Routing\Redirector
*/
public function destroy(Category \$category)
public function destroy(Request \$request, Category \$category)
{
\$this->authorize('delete', \$category);
request()->validate([
'category_id' => 'required',
]);
\$request->validate(['category_id' => 'required']);
if (request('category_id') == \$category->id && \$category->delete()) {
if (\$request->get('category_id') == \$category->id && \$category->delete()) {
return redirect()->route('categories.index');
}
@ -378,18 +376,17 @@ class CategoryController extends Controller
/**
* Remove the specified category from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \App\Entities\References\Category \$category
* @return \Illuminate\Routing\Redirector
*/
public function destroy(Category \$category)
public function destroy(Request \$request, Category \$category)
{
\$this->authorize('delete', \$category);
request()->validate([
'category_id' => 'required',
]);
\$request->validate(['category_id' => 'required']);
if (request('category_id') == \$category->id && \$category->delete()) {
if (\$request->get('category_id') == \$category->id && \$category->delete()) {
return redirect()->route('categories.index');
}

27
tests/Generators/Simple/SimpleControllerGeneratorTest.php

@ -86,18 +86,17 @@ class {$this->model_name}Controller extends Controller
/**
* Remove the specified {$this->single_model_var_name} from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \\{$this->full_model_name} \${$this->single_model_var_name}
* @return \Illuminate\Routing\Redirector
*/
public function destroy({$this->model_name} \${$this->single_model_var_name})
public function destroy(Request \$request, {$this->model_name} \${$this->single_model_var_name})
{
\$this->authorize('delete', \${$this->single_model_var_name});
request()->validate([
'{$this->lang_name}_id' => 'required',
]);
\$request->validate(['{$this->lang_name}_id' => 'required']);
if (request('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
if (\$request->get('{$this->lang_name}_id') == \${$this->single_model_var_name}->id && \${$this->single_model_var_name}->delete()) {
\$routeParam = request()->only('page', 'q');
return redirect()->route('{$this->table_name}.index', \$routeParam);
@ -190,18 +189,17 @@ class CategoryController extends Controller
/**
* Remove the specified category from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \App\Entities\References\Category \$category
* @return \Illuminate\Routing\Redirector
*/
public function destroy(Category \$category)
public function destroy(Request \$request, Category \$category)
{
\$this->authorize('delete', \$category);
request()->validate([
'category_id' => 'required',
]);
\$request->validate(['category_id' => 'required']);
if (request('category_id') == \$category->id && \$category->delete()) {
if (\$request->get('category_id') == \$category->id && \$category->delete()) {
\$routeParam = request()->only('page', 'q');
return redirect()->route('categories.index', \$routeParam);
@ -295,18 +293,17 @@ class CategoryController extends Controller
/**
* Remove the specified category from storage.
*
* @param \Illuminate\Http\Request \$request
* @param \App\Entities\References\Category \$category
* @return \Illuminate\Routing\Redirector
*/
public function destroy(Category \$category)
public function destroy(Request \$request, Category \$category)
{
\$this->authorize('delete', \$category);
request()->validate([
'category_id' => 'required',
]);
\$request->validate(['category_id' => 'required']);
if (request('category_id') == \$category->id && \$category->delete()) {
if (\$request->get('category_id') == \$category->id && \$category->delete()) {
\$routeParam = request()->only('page', 'q');
return redirect()->route('categories.index', \$routeParam);

Loading…
Cancel
Save